Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/wg 381 assets view image video no asset #292

Merged
merged 11 commits into from
Dec 17, 2024
Merged

Task/wg 381 assets view image video no asset #292

merged 11 commits into from
Dec 17, 2024

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Dec 12, 2024 •
edited
Loading

Overview:

Create asset detail panel similar to current prod angular detail panel

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Adds place and styles for panel on MapProject page
  • Changes useCurrentFeature hook so that it picks up the latest query accurately
  • Creates asset detail component with styles
  • Creates asset detail placeholders for questionnaire and pointcloud
  • Need to add meaningful test

Testing Steps:

  1. Click a map and click around various assets with the page and make sure they appear in the display panel
  2. Check video, image, point, and geometry type assets to make sure they display as expected
  3. Click the same highlighted asset and make sure the panel and search param disappears
  4. Go to different map and make sure it displays as expected.

NOTES:

  • Questionnaires and pointclouds are a follow on.
  • Add an asset for a feature with no asset button currently doesn't work.
  • Download button currently doesn't work

UI Photos:

Movies

Screenshot 2024-12-12 at 4 49 00 PM

###Images
Screenshot 2024-12-12 at 4 49 52 PM

Points:

Screenshot 2024-12-12 at 4 50 37 PM

Notes:

@sophia-massie
task/WG-381-Assets-View-Image-Video-No-Asset
8c6c0da 
- Adds place and styles for panel on MapProject page
@sophia-massie
- Changes useCurrentFeature hook so that it picks
a14fb68 
up the latest query accurately
- Creates asset detail component with styles
- Creates asset detail placeholders for questionnaire and pointcloud
- Need to add meaningful test
nathanfranklin
nathanfranklin approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sophia-massie
- Removes unused test render
35d650b
@sophia-massie
Catches weird cases where display_path does not
c8588c9 
exist but file tree uses asset.id before selectedFeature.id
- See v3_PROD_Hazmapper_2024-08-07_Test map to check
@sophia-massie sophia-massie merged commit 04a764f into main Dec 17, 2024
5 checks passed
@sophia-massie sophia-massie deleted the task/WG-381-Assets-View-Image-Video-No-Asset branch December 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin approved these changes

@shayanaijaz shayanaijaz Awaiting requested review from shayanaijaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophia-massie @nathanfranklin